Skip to content

Fix cross RP parent-child dependency#505

Merged
magodo merged 1 commit intoAzure:mainfrom
magodo:cross_rp_parent_child_dep
Feb 27, 2024
Merged

Fix cross RP parent-child dependency#505
magodo merged 1 commit intoAzure:mainfrom
magodo:cross_rp_parent_child_dep

Conversation

@magodo
Copy link
Copy Markdown
Collaborator

@magodo magodo commented Feb 24, 2024 •
edited
Loading

In #455, the armid package is updated to include the change magodo/armid@7d1b8af, which requires adoption in aztfexport to keep the cross rp parent-child dependencies.

E.g.

Before #455, and with this RP. We can get below when exporting a RG contains ACR:

resource "azurerm_container_registry" "res-1" {
  #...
  depends_on = [
    azurerm_resource_group.res-0,
  ]
}

But since #455 without this RP, we won't get the above depends_on.

@magodo magodo added the bug Something isn't working label Feb 24, 2024
@magodo magodo requested a review from ms-henglu February 24, 2024 03:39
ms-henglu
ms-henglu approved these changes Feb 27, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@ms-henglu ms-henglu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@magodo magodo merged commit d2f4390 into Azure:main Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ms-henglu ms-henglu ms-henglu approved these changes

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@magodo @ms-henglu