Skip to content

fix: Update acr credential provider setup#329

Merged
haofan-ms merged 4 commits intomasterfrom
users/hafa/fix-credential-provider
Aug 5, 2025
Merged

fix: Update acr credential provider setup#329
haofan-ms merged 4 commits intomasterfrom
users/hafa/fix-credential-provider

Conversation

@haofan-ms
Copy link
Contributor

Reason for Change:

Issue Fixed:

Credit Where Due:

Does this change contain code from or inspired by another project?

  • No
  • Yes

If "Yes," did you notify that project's maintainers and provide attribution?

  • No
  • Yes

Requirements:

Notes:

jadarsie
jadarsie previously approved these changes Jul 14, 2025
jadarsie
jadarsie previously approved these changes Jul 15, 2025
@haofan-ms haofan-ms force-pushed the users/hafa/fix-credential-provider branch 2 times, most recently from 9ce2b27 to 8d4ab70 Compare July 15, 2025 22:04
@haofan-ms haofan-ms requested a review from jadarsie July 15, 2025 22:11
@haofan-ms haofan-ms force-pushed the users/hafa/fix-credential-provider branch from 5aeb40b to 977970f Compare July 15, 2025 22:13
@haofan-ms haofan-ms force-pushed the users/hafa/fix-credential-provider branch from 977970f to fd7bb18 Compare July 15, 2025 22:15
Copy link
Member

@jadarsie jadarsie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to update documentation to reflect the change in the default config file and explain that the SPN needs pull access local ACRs

@haofan-ms haofan-ms force-pushed the users/hafa/fix-credential-provider branch from ff90950 to a90b1fe Compare July 17, 2025 22:05
@haofan-ms haofan-ms merged commit 4c91579 into master Aug 5, 2025
2 checks passed
@haofan-ms haofan-ms deleted the users/hafa/fix-credential-provider branch August 5, 2025 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants