chore: Remove deprecated "azure-container-registry-config" flag for kubelet#306
Merged
chore: Remove deprecated "azure-container-registry-config" flag for kubelet#306
Conversation
b32424b to
e4191ed
Compare
jadarsie
requested changes
Mar 19, 2025
Member
jadarsie
left a comment
There was a problem hiding this comment.
I think we have to modify validate.go instead of upgrade.go.
Contributor
Author
I updated both places, but from the test result only the messages from upgrade.go shows up in the console. Also our earlier api model overwrites all happen in upgrade.go, so I was thinking it make more sense to change there. |
jadarsie
approved these changes
Mar 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Issue Fixed:
Credit Where Due:
Does this change contain code from or inspired by another project?
If "Yes," did you notify that project's maintainers and provide attribution?
Requirements:
Notes: