Skip to content

fix: Fix enableTelemetry apiVersion and ARM template#281

Merged
christinalau0 merged 4 commits intoAzure:masterfrom
christinalau0:fix-enable-telemetry
Nov 20, 2024
Merged

fix: Fix enableTelemetry apiVersion and ARM template#281
christinalau0 merged 4 commits intoAzure:masterfrom
christinalau0:fix-enable-telemetry

Conversation

@christinalau0
Copy link
Contributor

@christinalau0 christinalau0 commented Nov 19, 2024

Reason for Change:

Specifying feature flag enableTelemetry: True would cause the ARM template deployment to fail. This PR bumps the api version and removes the DeploymentARMResource alias to fix the issue.

Issue Fixed:

Credit Where Due:

Does this change contain code from or inspired by another project?

  • No
  • Yes

If "Yes," did you notify that project's maintainers and provide attribution?

  • No
  • Yes

Requirements:

Notes:

jadarsie
jadarsie previously approved these changes Nov 19, 2024
@christinalau0 christinalau0 changed the title fix: Remove DeploymentARMResource alias in enableTelemetry code path fix: Fix enableTelemetry apiVersion and ARM template Nov 20, 2024
@christinalau0
Copy link
Contributor Author

Verified successful run with ADO PR E2E pipeline

@christinalau0 christinalau0 merged commit f3635b5 into Azure:master Nov 20, 2024
@christinalau0 christinalau0 deleted the fix-enable-telemetry branch November 20, 2024 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants