Skip to content

chore: remove usage of module autorest/azure#256

Merged
jadarsie merged 6 commits intoAzure:masterfrom
christinalau0:remove-autorest-azure-2
Jun 5, 2024
Merged

chore: remove usage of module autorest/azure#256
jadarsie merged 6 commits intoAzure:masterfrom
christinalau0:remove-autorest-azure-2

Conversation

@christinalau0
Copy link
Contributor

Reason for Change:

This PR removes the usage of module autorest/azure:

  1. It uses its own Environment structs in pkg/api/types.go.
  2. It removes the usage of helper method EnvironmentFromName.

Issue Fixed:

Credit Where Due:

Does this change contain code from or inspired by another project?

  • No
  • Yes

If "Yes," did you notify that project's maintainers and provide attribution?

  • No
  • Yes

Requirements:

Notes:

@christinalau0 christinalau0 requested a review from jadarsie as a code owner June 4, 2024 18:22
@christinalau0 christinalau0 requested review from haofan-ms and honcao June 4, 2024 18:22
@christinalau0
Copy link
Contributor Author

Validated with obp pr-e2e pipeline.

@jadarsie jadarsie merged commit 6bc4f90 into Azure:master Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants