Skip to content

SONIC VRF HLD 1.2#435

Merged
prsunny merged 3 commits intosonic-net:masterfrom
shine4chen:83-master
Sep 12, 2019
Merged

SONIC VRF HLD 1.2#435
prsunny merged 3 commits intosonic-net:masterfrom
shine4chen:83-master

Conversation

@shine4chen
Copy link
Copy Markdown
Contributor

@shine4chen shine4chen commented Aug 1, 2019

Nephos cooperate with brcm for this version.

  • update on loopback device
  • enhance frr template for vrf and static route configuration
  • decrease vrf-name len to 15 for kernel limitation

@preetham-singh

@shine4chen
Copy link
Copy Markdown
Contributor Author

@prsunny

Copy link
Copy Markdown
Collaborator

@venkatmahalingam venkatmahalingam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

VRF_NAME = 1*16VCHAR ;

This should be 1*15VCHAR ;, please change it.

root@sonic:/# ip link add Vrf-12345678910 type vrf table 10
root@sonic:/# ip link add Vrf-123456789101 type vrf table 11
Error: argument "Vrf-123456789101" is wrong: "name" too long

root@sonic:/#

Copy link
Copy Markdown
Collaborator

@venkatmahalingam venkatmahalingam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Route leak support:
Looks like we have not captured the case "route leaking for directly connected destinations (not thru nexthops) in another VRF", don't we have this use-case?

@preetham-singh
Copy link
Copy Markdown
Contributor

Route leak support:
Looks like we have not captured the case "route leaking for directly connected destinations (not thru nexthops) in another VRF", don't we have this use-case?

Connected route leak feature was already supported as part of VRF HLD 1.1.
We missed to list this as part of VRF HLD 1.1.
@prsunny / @shine4chen
Perhaps we can update route leak section?

@shine4chen
Copy link
Copy Markdown
Contributor Author

shine4chen commented Aug 4, 2019

@venkatmahalingam good point, I will change it. Thanks

VRF_NAME = 1*16VCHAR ;

This should be 1*15VCHAR ;, please change it.

root@sonic:/# ip link add Vrf-12345678910 type vrf table 10
root@sonic:/# ip link add Vrf-123456789101 type vrf table 11
Error: argument "Vrf-123456789101" is wrong: "name" too long

root@sonic:/#

@venkatmahalingam good point , thanks. I will change it.

@shine4chen
Copy link
Copy Markdown
Contributor Author

shine4chen commented Aug 4, 2019

Route leak support:
Looks like we have not captured the case "route leaking for directly connected destinations (not thru nexthops) in another VRF", don't we have this use-case?

Connected route leak feature was already supported as part of VRF HLD 1.1.
We missed to list this as part of VRF HLD 1.1.
@prsunny / @shine4chen
Perhaps we can update route leak section?

@preetham-singh Yes , I will update it in HLD 1.2

@shine4chen
Copy link
Copy Markdown
Contributor Author

@prsunny update HLD for acl-redirect schema backward compatibility

Copy link
Copy Markdown

@karthikarum karthikarum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine with the changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants