Fixes AB#925: Correct core count on job pool picker

gingi · gingi · commit b63287a8bac5 · 2023-05-30T15:06:13.000-04:00
diff --git a/desktop/i18n/resources.resjson b/desktop/i18n/resources.resjson
@@ -239,8 +239,11 @@
   "pool-os-picker.category.rendering": "Graphics and rendering",
   "pool-os-picker.containerConfiguration": "Container configuration",
   "pool-os-picker.nodeAgentSelection": "Based on your selection, node agent '{sku}' will be used",
+  "pool-picker.coreCount": "core count",
+  "pool-picker.description": "Showing pools with a container image matching {filters}",
   "pool-picker.filterByID": "Search by id",
   "pool-picker.filterByOS": "Filter by OS",
+  "pool-picker.nodeCount": "node count",
   "pool-picker.noneMatching": "You don't have any pools matching the current filters.",
   "pool-picker.reset": "Reset",
   "pool-scale-picker.evaluationInterval.label": "Formula evaluation interval",
diff --git a/desktop/src/app/components/job/action/add/pool-picker/pool-picker.html b/desktop/src/app/components/job/action/add/pool-picker/pool-picker.html
@@ -23,13 +23,13 @@
         <div class="info">
             <div class="title" [title]="pool.id">{{pool.id}}</div >
             <div class="details">
-                <div title="Pool has {{pool.targetNodes}} nodes" class="metric">
+                <div title="{{'pool-picker.nodeCount' | i18n}}: {{pool.targetNodes}}" class="metric">
                     <i class="fa fa-tv" aria-hidden="true"></i>
-                    <span attr.aria-label="{{pool.targetNodes}} nodes">{{pool.targetNodes}}</span>
+                    <span>{{pool.targetNodes}}</span>
                 </div>
-                <div title="Pool has {{poolCoreCount(pool)}} cores" class="metric">
+                <div title="{{'pool-picker.coreCount' | i18n }}: {{poolCoreCount(pool)}}" class="metric">
                     <i class="fa fa-microchip" aria-hidden="true"></i>
-                    <span attr.aria-label="{{pool.targetNodes}} cores">{{poolCoreCount(pool)}}</span>
+                    <span>{{poolCoreCount(pool)}}</span>
                 </div>
                 <div class="pool-tags">
                     <bl-tags [tags]="pool.tags" [maxTags]="3"></bl-tags>
diff --git a/desktop/src/app/components/job/action/add/pool-picker/pool-picker.i18n.yml b/desktop/src/app/components/job/action/add/pool-picker/pool-picker.i18n.yml
@@ -3,3 +3,5 @@ pool-picker:
   filterByID: Search by id
   reset: Reset
   noneMatching: You don't have any pools matching the current filters.
+  coreCount: core count
+  nodeCount: node count
