Fixes AB#488: ARIA label for select includes value

gingi · gingi · commit 9678ca576835 · 2023-01-13T13:20:12.000-05:00
diff --git a/src/@batch-flask/ui/select/select.component.spec.ts b/src/@batch-flask/ui/select/select.component.spec.ts
@@ -120,12 +120,14 @@ describe("SelectComponent", () => {
 
         it("Should show placeholder when no value", () => {
             expect(labelEl.nativeElement.textContent).toContain("Myselect");
+            expect(de.nativeElement.getAttribute("aria-label")).toContain("Myselect");
         });
 
         it("Should show value when picked", () => {
             testComponent.value.setValue("opt-3");
             fixture.detectChanges();
             expect(labelEl.nativeElement.textContent).toContain("Carrot");
+            expect(de.nativeElement.getAttribute("aria-label")).toEqual("Myselect: Carrot");
         });
 
         it("list all options when clicking on button", async () => {
diff --git a/src/@batch-flask/ui/select/select.component.ts b/src/@batch-flask/ui/select/select.component.ts
@@ -116,7 +116,7 @@ export class SelectComponent<TValue = any> implements FormFieldControl<any>, Opt
     @HostBinding("attr.aria-haspopup") public readonly ariaHasPopup = "listbox";
     @Input("attr.aria-label") @HostBinding("attr.aria-label")
     public set ariaLabel(label: string) { this._ariaLabel = label; }
-    public get ariaLabel() { return this._ariaLabel || this.placeholder; }
+    public get ariaLabel() { return this._ariaLabel || this.title; }
     @HostBinding("attr.aria-expanded") public get ariaExpanded() { return this.dropdownOpen; }
     @HostBinding("attr.aria-owns") public get ariaOwns() { return this.dropdownId; }
     @HostBinding("attr.tabindex") public readonly tabindex = -1;
