Ensures that warning messages are read

gingi · gingi · commit 1aa4a7417c25 · 2023-01-20T11:00:25.000-05:00
Adds aria-live attribute to certain elements that convey warning status.

Removes outdated warning (2019)

Fixes AB#525, AB#566
diff --git a/src/@batch-flask/ui/property-list/property-group/property-group.html b/src/@batch-flask/ui/property-list/property-group/property-group.html
@@ -10,7 +10,7 @@ <h4 class="noselect">{{label}}</h4>
     <bl-button color="light" type="round" [action]="triggerEdit" *ngIf="edit" title="Edit"><i class="fa fa-pencil"></i></bl-button>
 </bl-clickable>
 <div class="group-content" *ngIf="!collapsed" [id]="contentId">
-    <div class="warning-message" *ngIf="warningMessage">
+    <div class="warning-message" *ngIf="warningMessage" aria-live="polite">
         <i class="fa fa-warning"></i>
         <span>{{warningMessage}}</span>
     </div>
diff --git a/src/app/components/account/details/programatic-usage/aad-credentials-picker/aad-credentials-picker.html b/src/app/components/account/details/programatic-usage/aad-credentials-picker/aad-credentials-picker.html
@@ -23,7 +23,7 @@ <h1>AAD Credentials</h1>
             <bl-property-group>
                 <bl-text-property label="Tenant Id" [value]="tenantId"></bl-text-property>
                 <bl-text-property label="Client Id" [value]="pickedApplication.id"></bl-text-property>
-                <div class="danger">
+                <div class="danger" aria-live="polite">
                     <i class="fa fa-warning"></i>Save this key, you will not see it again after closing this dialog.
                 </div>
                 <bl-text-property label="Secret" [value]="pickedSecret.value"></bl-text-property>
diff --git a/src/app/components/account/details/programatic-usage/programatic-usage.html b/src/app/components/account/details/programatic-usage/programatic-usage.html
@@ -17,7 +17,7 @@ <h1>
             <div>
                 {{'programatic-usage.credentials' | i18n}}
             </div>
-            <div *ngIf="pickedCredentialType === CredentialType.AAD && !aadCredentials" class="aad-needs-setup-creds"
+            <div *ngIf="pickedCredentialType === CredentialType.AAD && !aadCredentials" class="aad-needs-setup-creds" aria-live="polite"
                 matTooltip="Pick an application and generate a key to have the templates filled with the correct informations">
                 <i class="fa fa-warning"></i>{{'programatic-usage.setup' | i18n}}
             </div>
diff --git a/src/app/components/account/details/programatic-usage/programing-sample/programing-sample.html b/src/app/components/account/details/programatic-usage/programing-sample/programing-sample.html
@@ -1,5 +1,5 @@
 <div class="description">
-    <div *ngIf="credentialType === CredentialType.AAD && !aadCredentials" class="aad-needs-setup-creds">
+    <div *ngIf="credentialType === CredentialType.AAD && !aadCredentials" class="aad-needs-setup-creds" aria-live="polite">
         <i class="fa fa-warning"></i>You haven't picked an Azure AD application yet. The sample below will not have all the information filled.
     </div>
     <bl-property-group label="" class="wide" class="prerequisites">
diff --git a/src/app/components/data/action/delete/delete-container-dialog.html b/src/app/components/data/action/delete/delete-container-dialog.html
@@ -7,7 +7,7 @@
                 {{ container.name}}
             </li>
         </ul>
-        <div class="warning-message">
+        <div class="warning-message" aria-live="polite">
             <i class="fa fa-warning"></i>&nbsp;
             <span>{{"delete-container-dialog.warning" | i18n}}</span>
         </div>
diff --git a/src/app/components/job/details/job-progress-status/job-progress-status.html b/src/app/components/job/details/job-progress-status/job-progress-status.html
@@ -21,7 +21,7 @@
         </div>
     </div>
 </div>
-<div class="warning-container">
+<div class="warning-container" aria-live="polite">
     <div class="unaccurate-data" *ngIf="taskCountTooHigh">
         <i class="fa fa-warning"></i>{{'job-progress-status.inaccurate' | i18n}}
     </div>
diff --git a/src/app/components/pool/details/pool-cost-card/pool-cost-card.html b/src/app/components/pool/details/pool-cost-card/pool-cost-card.html
@@ -7,13 +7,4 @@
             [attr.aria-label]="label">
         </canvas>
     </div>
-    <div class="total">
-        <i *ngIf="showPartialDataWarning" class="fa fa-warning" matTooltip="Cost tracking at the pool level is a recent change. Data will be missing before April 2019"></i>
-        <bl-time-range-picker [formControl]="timeRange" [quickRanges]="quickRanges" [showLabel]="false"></bl-time-range-picker>
-
-        <i *ngIf="loading" class="fa fa-spiner fa-spin"  title="Loading"></i>
-        <span *ngIf="!loading">
-            {{total}} {{currency}}
-        </span>
-    </div>
 </ng-container>
diff --git a/src/app/components/task/base/task-state/task-state.html b/src/app/components/task/base/task-state/task-state.html
@@ -1,4 +1,4 @@
-<span [matTooltip]="errorMessage" matTooltipPosition="right">
+<span [matTooltip]="errorMessage" matTooltipPosition="right" aria-live="polite">
     <i class="fa"
         aria-hidden="true"
         [class.fa-warning]="hasError"

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-<span [matTooltip]="errorMessage" matTooltipPosition="right">`
	`1`	`+<span [matTooltip]="errorMessage" matTooltipPosition="right" aria-live="polite">`
`2`	`2`	`<i class="fa"`
`3`	`3`	`aria-hidden="true"`
`4`	`4`	`[class.fa-warning]="hasError"`