Encode filename in downloadFromNode and downloadFromTask methods (#2862)

wanghoppe · hoppe · web-flow · commit 140c9581a715 · 2023-12-21T15:24:27.000Z
Co-authored-by: hoppe &lt;hoppewang@microsoft.com&gt;
diff --git a/desktop/src/app/services/azure-batch/file/file.service.ts b/desktop/src/app/services/azure-batch/file/file.service.ts
@@ -246,10 +246,12 @@ export class FileService {
     }
 
     public downloadFromNode(poolId: string, nodeId: string, filename: string, dest: string) {
+        filename = encodeURIComponent(filename);
         return this._download(`/pools/${poolId}/nodes/${nodeId}/files/${filename}`, dest);
     }
 
     public downloadFromTask(jobId: string, taskId: string, filename: string, dest: string) {
+        filename = encodeURIComponent(filename);
         return this._download(`/jobs/${jobId}/tasks/${taskId}/files/${filename}`, dest);
 
     }

Original file line number	Diff line number	Diff line change
`@@ -246,10 +246,12 @@ export class FileService {`
`246`	`246`	`}`
`247`	`247`
`248`	`248`	`public downloadFromNode(poolId: string, nodeId: string, filename: string, dest: string) {`
	`249`	`+ filename = encodeURIComponent(filename);`
`249`	`250`	return this._download(`/pools/${poolId}/nodes/${nodeId}/files/${filename}`, dest);
`250`	`251`	`}`
`251`	`252`
`252`	`253`	`public downloadFromTask(jobId: string, taskId: string, filename: string, dest: string) {`
	`254`	`+ filename = encodeURIComponent(filename);`
`253`	`255`	return this._download(`/jobs/${jobId}/tasks/${taskId}/files/${filename}`, dest);
`254`	`256`
`255`	`257`	`}`