populate form setValues to subForm (#2801)

wanghoppe · hoppe · web-flow · commit 02e6dffbed67 · 2023-09-14T14:58:40.000Z
* fix: npm run watch on packages

* populate setValues to subForm

* back to deep copy

---------

Co-authored-by: hoppe &lt;hoppewang@microsoft.com&gt;
diff --git a/packages/bonito-core/src/form/__tests__/form.spec.ts b/packages/bonito-core/src/form/__tests__/form.spec.ts
@@ -284,6 +284,18 @@ describe("Form tests", () => {
                 },
             }
         );
+
+        // form.setValues() should set the values of the subForm
+        form.setValues({
+            ...form.values,
+            answers: {
+                color: "yellow",
+            },
+        });
+
+        expect(subForm.values).toEqual({
+            color: "yellow",
+        });
     });
 
     test("Validation", async () => {
diff --git a/packages/bonito-core/src/form/internal/form-impl.ts b/packages/bonito-core/src/form/internal/form-impl.ts
@@ -256,6 +256,11 @@ export class FormImpl<V extends FormValues> implements Form<V> {
             return;
         }
         this._values = values;
+        for (const e of this.allEntries()) {
+            if (e instanceof SubForm) {
+                e.setValues(values[e.name]);
+            }
+        }
         this._formValuesChanged(values, oldValues);
     }
 

Original file line number	Diff line number	Diff line change
`@@ -256,6 +256,11 @@ export class FormImpl<V extends FormValues> implements Form<V> {`
`256`	`256`	`return;`
`257`	`257`	`}`
`258`	`258`	`this._values = values;`
	`259`	`+ for (const e of this.allEntries()) {`
	`260`	`+ if (e instanceof SubForm) {`
	`261`	`+ e.setValues(values[e.name]);`
	`262`	`+ }`
	`263`	`+ }`
`259`	`264`	`this._formValuesChanged(values, oldValues);`
`260`	`265`	`}`
`261`	`266`