Fix SelfInfo frame length validation#256
Merged
Merged
Conversation
Avi0n
requested changes
Mar 17, 2026
Avi0n
left a comment
Owner
There was a problem hiding this comment.
Thank you for this PR! Once the review changes are addressed, I'll merge this.
Avi0n
approved these changes
Mar 17, 2026
Owner
|
LGTM, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PacketSize.selfInfoMinimumfrom 55 to 57 bytesSelfInfopayload and for truncated payload rejectionWhy this is the correct fix
The current MeshCore firmware documentation describes
PACKET_SELF_INFOas:References:
docs/companion_protocol.md(PACKET_SELF_INFO)PacketParserdrops the response code before parsing, so the parser should require a minimum payload length of 57 bytes, not 55. With the old boundary, malformed frames missingradioSF/radioCRcould still pass the initial size check and then be parsed incorrectly.This change tightens validation to match the documented fixed-width frame while preserving valid firmware behavior, including payloads with no trailing device name.
Testing
Automated:
cd MeshCore && swift testSelfInfopayload with no device nameSelfInfopayload rejected with parse failureManual on device:
selfInforeception, sync, and repeater interaction all still workRelevant log proof from the successful on-device run:
That gives both sides of the validation: the new parser still accepts real firmware frames on hardware, and the new tests prove truncated frames are rejected.