Conversation
|
@perarnborg Now block is always shown in editor-mode using is_gutenberg_request(), ignoring scheduling settings. Like you mentioned, perhaps some visual clue would be nice when block is hidden and/or have an active scheduling in editor mode. Also: json block settings is not done! |
…k render callback
perarnborg
left a comment
There was a problem hiding this comment.
Looks great!
I have added a config setting so only block types that are meant to be scheduled get the behaviour, and also I moved the publish date check from the block_args to the render callback. This is because some implementations of the plugin can have a behaviour where they want a block to show even if there are not posts in it. Those blocks would still show up with the previous implementatoin since whate we did there was to set the posts array to an empty list.
Good job!!
|
Also added styling in editor (opacity: 0.4) for unpublished blocks. |
Closes #114
WIP see comments below.