Add NixOS module #734
Merged
Add NixOS module #734
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LuckShiba
reviewed
Nov 16, 2025
distro/nix/nixos.nix
Outdated
| cfg = config.programs.dankMaterialShell; | ||
| in { | ||
| imports = [ | ||
| (lib.mkRemovedOptionModule ["programs" "dankMaterialShell" "enableNightMode"] "Night mode is now always available.") |
Collaborator
There was a problem hiding this comment.
This option never existed (since the NixOS module, to begin with, never existed), so I think it's not needed here.
distro/nix/nixos.nix
Outdated
| Install.WantedBy = [config.wayland.systemd.target]; | ||
| }; | ||
|
|
||
| environment.systemPackages = |
Collaborator
There was a problem hiding this comment.
I think that the basic module options, specially the enable* ones should be in a single shared .nix file, imported by both home-manager and NixOS modules, since the packages and options are verbatim the same. If someone wanted to add a new dependency or modify the needed, they would always have to unnecessarily have to modify both files.
I can do this in another PR, if you want.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapted the HM module, removed the config stuff and changed the quickshell installation method.