Conversation
This is an automated check which relies on Generated by 🚫 dangerJS |
|
We recently removed |
4271d5c to
c424347
Compare
There was a problem hiding this comment.
| 'If left black, feedback will be sent to the author of the post and the subject will be the name of this post.' | |
| 'If left blank, feedback will be sent to the author of the post and the subject will be the name of this post.' |
There was a problem hiding this comment.
I fixed these. Good catch!
|
There's a number of inconsistencies as to whether or not the |
There was a problem hiding this comment.
Just noting that eventually we'll need to look into moving hardcoded colours into variables, especially since some of these are Gutenberg-core colours. Won't need to happen in this PR though.
See e.g. related posts block:
There was a problem hiding this comment.
Same with a lot of the other CSS properties and values as well. It's also always a good idea to start early.
|
Not a blocker for anything but just wanted to flag this. Wonder if we can improve on user expectations how the button will look like at the site: I'm using the latest In the editor— At the site— When I create a button block, I see a similar button like at the frontend:
Perhaps using button component would work visually better? |
This reverts commit 379d08432e2d9cdd743efee5709b9e8b538f102c.
218adff to
6a5338c
Compare
lezama
left a comment
There was a problem hiding this comment.
Great work everyone, 🚢 IT !
Let's keep iterating on following PRs
Syncing stuff from Automattic/jetpack#10256
This PR supersedes the prior PR, #27688
Most discussion has been on the Jetpack PR, where the bulk of active development has taken place.