Studio: Update php-wasm ( playground dependecies)#491
Merged
Conversation
… commands (eg core update)
Contributor
Author
|
Things I have tested:
|
Contributor
|
I smoke tested the app with the build from this branch and everything worked as expected. The only thing that I noticed is that this branch is about 20 - 30 seconds slower for me when importing a database. Steps to reproduce:
|
katinthehatsite
approved these changes
Aug 30, 2024
Contributor
katinthehatsite
left a comment
There was a problem hiding this comment.
I smoke tested the app, tried several different plugins and themes and everything is running as expected for me 👍
I noticed that sometimes importing could be slower compared to trunk but I was not able to reproduce this consistently so I am suspecting that it might be a specific import file at fault.
This was referenced Sep 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/Automattic/dotcom-forge/issues/8867
Proposed Changes
This PR updates the following packages to the latest version:
During the update we ran into various issues, some of which required changes in the wordpress-playground repository:
We had to change a couple of things in the current implementation of wp-now within Studio as it was relying on outdated APIs. These changes mainly relate to how we obtain a PHP instance.
Testing Instructions
Pre-merge Checklist