Skip to content

Update button cursor on hover for improved accessibility#7843

Merged
donnapep merged 2 commits intotrunkfrom
fix/button-accessibility
Aug 29, 2025
Merged

Update button cursor on hover for improved accessibility#7843
donnapep merged 2 commits intotrunkfrom
fix/button-accessibility

Conversation

@donnapep
Copy link
Copy Markdown
Member

@donnapep donnapep commented Aug 29, 2025

Partial solution for https://github.com/Automattic/sensei-pro/issues/2664.

Proposed Changes

This pull request introduces a minor usability improvement to the button styles. The change ensures that buttons display a pointer cursor on hover, making it clearer to users that the button is clickable.

  • Added cursor: pointer; to the .wp-block-button__link class in assets/blocks/button/button.scss to improve button interactivity.

Testing Instructions

  1. Hover over any button on the frontend.
  2. Ensure the cursor changes to indicate that the button can be clicked.

Pre-Merge Checklist

  • PR title and description contain sufficient detail and accurately describe the changes
  • Adheres to coding standards (PHP, JavaScript, CSS, HTML)
  • All strings are translatable (without concatenation, handles plurals)
  • Follows our naming conventions (P6rkRX-4oA-p2)
  • Hooks (p6rkRX-1uS-p2) and functions are documented
  • New UIs are responsive and use a mobile-first approach
  • Code is tested on the minimum supported PHP and WordPress versions

@donnapep donnapep self-assigned this Aug 29, 2025
Copilot AI review requested due to automatic review settings August 29, 2025 13:31
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a pointer cursor to button elements to improve user accessibility and usability by making it clearer that buttons are interactive elements.

  • Added cursor: pointer to the .wp-block-button__link class to enhance button interactivity
  • Improves visual feedback for users when hovering over buttons

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@donnapep donnapep changed the title Update button cursor for improved accessibility Update button cursor on hover for improved accessibility Aug 29, 2025
@donnapep donnapep added this to the 4.25.1 milestone Aug 29, 2025
@donnapep donnapep merged commit 3739c63 into trunk Aug 29, 2025
21 checks passed
@donnapep donnapep deleted the fix/button-accessibility branch August 29, 2025 13:50
@m1r0
Copy link
Copy Markdown
Member

m1r0 commented Sep 18, 2025

Love this! Thanks, Donna!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants