Fix invalid property notice for messages#7814
Merged
Conversation
Contributor
|
Test the previous changes of this PR with WordPress Playground. |
Contributor
|
Test the previous changes of this PR with WordPress Playground. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #6412.
Proposed Changes
In certain scenarios such as custom queries, the global
$postvariable may not be set or may not be an instance ofWP_Post. This can occur ifthe_contentis applied outside the main loop or if other plugins/themes manipulate the global$postvariable.To be safe, switching to using
get_postinstead.Testing Instructions
N/A. I wasn't able to reproduce, but the code now does an extra check that
$postis actually an instance ofWP_Postbefore trying to access theIDproperty.Pre-Merge Checklist