Conversation
Contributor
|
Test the previous changes of this PR with WordPress Playground. |
Contributor
|
Test the previous changes of this PR with WordPress Playground. |
renatho
commented
Mar 31, 2025
| 'menu_order' => $i, | ||
| ); | ||
|
|
||
| // If you face performance issues on Simple Sites, see https://github.com/Automattic/sensei/pull/7799. |
Contributor
Author
There was a problem hiding this comment.
I added this comment, so in case we face this issue again in the future, it's easier to find our previous tries and possible solutions.
bogiii
requested changes
Apr 1, 2025
Contributor
bogiii
left a comment
There was a problem hiding this comment.
Works as described. Nice finding. 👍
bogiii
approved these changes
Apr 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 19a00b2.
See issue reported p1743440666861309-slack-C07418EJ0
Proposed Changes
At some point, we made a change to improve a performance issue noticed on Learnomattic.
Now it's causing an issue in atomic sites on WPCOM, not ordering the courses at all. Given that currently Learnomattic doesn't have a page to list all the courses, it should not be a problem anymore, and we should prioritize user sites.
If we face this performance issue again for a specific type of environment, we need to find a different solution. Or if the reverted solution still works in this environment, we could try a conditional with the 2 approaches depending on the environment.
Testing Instructions
Pre-Merge Checklist