Skip to content

Alpha release Apr 04#3885

Merged
miguelpeixe merged 17 commits into
alphafrom
trunk
Apr 4, 2025
Merged

Alpha release Apr 04#3885
miguelpeixe merged 17 commits into
alphafrom
trunk

Conversation

@miguelpeixe

Copy link
Copy Markdown
Member

A new alpha release.

ronchambers and others added 17 commits March 26, 2025 14:23
This fixes an issue where resetting an email template in Newspack > Settings > Emails would only render Woo templates on success.
* feat: modify textarea to RichText and add TagInlineBlock with dummy authors

* feat: fetch authors from co-authors plus and set tokens on BylinesSettingsPanel

* chore: improve inline documentation

* feat: [WIP] add author tokens on click

* feat: append users to the end of the byline

* feat: add author tokens to custom byline

* feat: handling tokens with vanilla JS (WIP)

* feat: useRef to manage tokens in use

* chore: improve inline docs

* feat: check custom byline after DOM ready

* chore: addEventListener trough ref instead of DOM directly

Also adds the return of a function on useEffect to allow React cleanup on unmount

* feat: display icons on tokens (plus to insert and close to remove)

* feat: add mutation observer to remove tokens on erasing with backspace/delete

* chore: enhance inline documentation

* fix: stylize tokens according to FormTokenField

* fix: remove token when characterData changes

* fix: improved mutation observer callback logic to update data correctly

* fix: initilize only on DOM ready and main byline element ready

* fix: properly add the mutation observer after child component is ready

* fix: implement setTokensInUse function to better reuse code

* fix: split byline "textarea" and tokens to avoid unwanted re-rendering

* feat: parse meta with <Author> before rendering byline

* feat: store byline meta according to the expected format

* chore: refacot bylineParser function

* feat: make custom bylines to work without co-author plus activated

* feat: make custom byline field to be displayed on a modal

* fix: mystype newspackByline.is_co_authors_plus_active

* fix: adding space after token insertion at the end of byline

* fix: improve byline innerHTML assignment

* fix: typo isTokensdReady

* docs: update docs

* fix: remove non used authors query

* fix: cubic-bezier transition typo

* fix: remove updateBylineMeta from click on x/removal callback event

* fix: remove unnecessary "backwards" compatibility since it's new feature

* refactor: replace MutationObserver with event listeners

Replaced the MutationObserver with an event listener, replaced some of
the DOM interaction with a useRef element, and tried to refactor some of
the data getters and setters.

* fix: update effect registration so it only runs on mounting

* refactor: remove unneded "remove token" handler

* fix: look up the byline meta on mount, not just on initial render

* fix: set contenteditable="false" on token spans

Prevents editing the content in these spans, and makes it so that
deleting (with backspace) will remove the whole span at once rather than
editing within the span.

* chore: add some missing docblocks and fix some lint issues

* fix: set default insert location to end of editable field

Updates the "cursorPos" variable logic to use the end of the line if
there's no cursor position set yet, and to add a non-breaking space at
the end of the text if necessary. Also updates the white-space styling
of the editable area, to ensure that users can select any point in the
text they may need to.

* fix: remove margin from last token to prevent confusion with whitespace

* feat: add preview to sidebar interface

* fix: rename panel to Byline

* fix: make modal width fixed

* feat: add function to parse meta for preview

* feat: default custom byline on first toggle

* feat: set default custom byline meta on toggle

* feat: update styles to match new designs

* feat: update styles to match designs

* chore: cleanup, comments, organization

---------

Co-authored-by: Leo Germani <leogermani@automattic.com>
Co-authored-by: goldenapples <goldenapplesdesign@gmail.com>
Co-authored-by: Joeleen Kennedy <joeleen@humanmade.com>
* feat: modify textarea to RichText and add TagInlineBlock with dummy authors

* feat: fetch authors from co-authors plus and set tokens on BylinesSettingsPanel

* chore: improve inline documentation

* feat: [WIP] add author tokens on click

* feat: append users to the end of the byline

* feat: add author tokens to custom byline

* feat: handling tokens with vanilla JS (WIP)

* feat: useRef to manage tokens in use

* chore: improve inline docs

* feat: check custom byline after DOM ready

* chore: addEventListener trough ref instead of DOM directly

Also adds the return of a function on useEffect to allow React cleanup on unmount

* feat: display icons on tokens (plus to insert and close to remove)

* feat: add mutation observer to remove tokens on erasing with backspace/delete

* chore: enhance inline documentation

* fix: stylize tokens according to FormTokenField

* fix: remove token when characterData changes

* fix: improved mutation observer callback logic to update data correctly

* fix: initilize only on DOM ready and main byline element ready

* fix: properly add the mutation observer after child component is ready

* fix: implement setTokensInUse function to better reuse code

* fix: split byline "textarea" and tokens to avoid unwanted re-rendering

* feat: parse meta with <Author> before rendering byline

* feat: store byline meta according to the expected format

* chore: refacot bylineParser function

* feat: make custom bylines to work without co-author plus activated

* feat: make custom byline field to be displayed on a modal

* fix: mystype newspackByline.is_co_authors_plus_active

* fix: adding space after token insertion at the end of byline

* fix: improve byline innerHTML assignment

* docs: update docs

* fix: typo isTokensdReady

* fix: remove non used authors query

* fix: cubic-bezier transition typo

* fix: remove updateBylineMeta from click on x/removal callback event

* fix: remove unnecessary "backwards" compatibility since it's new feature

* feat: add byline output to pre_newspack_posted_by hook

* Tried to simplify some things

Replaced the MutationObserver with an event listener, replaced some of
the DOM interaction with a useRef element, and tried to refactor some of
the data getters and setters.

* Update effects on mounting

* Remove unneded remove handler.

* Look up the byline on mount, not just on initial render.

* feat: modify textarea to RichText and add TagInlineBlock with dummy authors

* feat: fetch authors from co-authors plus and set tokens on BylinesSettingsPanel

* chore: improve inline documentation

* feat: [WIP] add author tokens on click

* feat: append users to the end of the byline

* feat: add author tokens to custom byline

* feat: handling tokens with vanilla JS (WIP)

* feat: useRef to manage tokens in use

* chore: improve inline docs

* feat: check custom byline after DOM ready

* chore: addEventListener trough ref instead of DOM directly

Also adds the return of a function on useEffect to allow React cleanup on unmount

* feat: display icons on tokens (plus to insert and close to remove)

* feat: add mutation observer to remove tokens on erasing with backspace/delete

* chore: enhance inline documentation

* fix: stylize tokens according to FormTokenField

* fix: remove token when characterData changes

* fix: improved mutation observer callback logic to update data correctly

* fix: initilize only on DOM ready and main byline element ready

* fix: properly add the mutation observer after child component is ready

* fix: implement setTokensInUse function to better reuse code

* fix: split byline "textarea" and tokens to avoid unwanted re-rendering

* feat: parse meta with <Author> before rendering byline

* feat: store byline meta according to the expected format

* chore: refacot bylineParser function

* feat: make custom bylines to work without co-author plus activated

* feat: make custom byline field to be displayed on a modal

* fix: mystype newspackByline.is_co_authors_plus_active

* fix: adding space after token insertion at the end of byline

* fix: improve byline innerHTML assignment

* fix: typo isTokensdReady

* docs: update docs

* fix: remove non used authors query

* fix: cubic-bezier transition typo

* fix: remove updateBylineMeta from click on x/removal callback event

* fix: remove unnecessary "backwards" compatibility since it's new feature

* refactor: replace MutationObserver with event listeners

Replaced the MutationObserver with an event listener, replaced some of
the DOM interaction with a useRef element, and tried to refactor some of
the data getters and setters.

* fix: update effect registration so it only runs on mounting

* refactor: remove unneded "remove token" handler

* fix: look up the byline meta on mount, not just on initial render

* fix: set contenteditable="false" on token spans

Prevents editing the content in these spans, and makes it so that
deleting (with backspace) will remove the whole span at once rather than
editing within the span.

* chore: add some missing docblocks and fix some lint issues

* fix: set default insert location to end of editable field

Updates the "cursorPos" variable logic to use the end of the line if
there's no cursor position set yet, and to add a non-breaking space at
the end of the text if necessary. Also updates the white-space styling
of the editable area, to ensure that users can select any point in the
text they may need to.

* fix: remove margin from last token to prevent confusion with whitespace

* feat: add preview to sidebar interface

* fix: rename panel to Byline

* fix: make modal width fixed

* feat: add function to parse meta for preview

* feat: default custom byline on first toggle

* feat: set default custom byline meta on toggle

* feat: replace author shortcodes on output

* feat: update styles to match new designs

* feat: update styles to match designs

* chore: cleanup, comments, organization

* feat: return an array of coauthors plus authors object, for authors in use in the byline

* chore: few tweaks and linting

---------

Co-authored-by: Leo Germani <leogermani@automattic.com>
Co-authored-by: goldenapples <goldenapplesdesign@gmail.com>
Co-authored-by: Joeleen Kennedy <joeleen@humanmade.com>
* fix: add constant contact list id setting

* fix: add constant contact to Sync settings

* fix: add constant contact to reader activation settings

* chore: refactor esp settings component

* fix: regressions

---------

Co-authored-by: dkoo <derrick.koo@automattic.com>
@miguelpeixe miguelpeixe requested a review from a team as a code owner April 4, 2025 13:53
@miguelpeixe miguelpeixe merged commit 121cc95 into alpha Apr 4, 2025
@matticbot

Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 6.3.0-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@matticbot

Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 6.4.0-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@matticbot

Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 6.4.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants