fix: move optional module settings from Syndication to own class#3858
Merged
Conversation
adekbadek
approved these changes
Mar 25, 2025
adekbadek
left a comment
Member
There was a problem hiding this comment.
Changes look and work ok, though I don't see the fatal on epic/ia.
Member
|
@dkoo is there anything blocking this merge? We should get IA to alphas. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
#3783 introduced another optional module, but one that's not related to the Syndication section in our dashboard. Since #3783 expects the optional module settings to be available in the
Newspack\Settingsclass, which has been deprecated with its methods moved to other classes throughout the wizard app, it's currently throwing a fatal.This PR moves all methods and constants related to optional modules to a new
Optional_Modulesclass for clarity.How to test the changes in this Pull Request:
epic/ia, observe a fatal error when loading any WP admin page.Other information: