Skip to content

feat: update ads and newsletter-ads icons#3836

Merged
thomasguillot merged 1 commit into
epic/iafrom
update/ad-icons
Mar 20, 2025
Merged

feat: update ads and newsletter-ads icons#3836
thomasguillot merged 1 commit into
epic/iafrom
update/ad-icons

Conversation

@thomasguillot

Copy link
Copy Markdown
Contributor

All Submissions:

Changes proposed in this Pull Request:

This PR updates the dashboard and sidebar menu icons for Advertising and Newsletter Ads, making them more distinguishable while maintaining a cohesive look. This helps clarify why there are two Advertising cards, reducing potential confusion.

Before
Before

After
After

How to test the changes in this Pull Request:

  1. Switch to this branch
  2. Check that the "Pullquote" icon has been replaced by the "Ad" icon and the "Envelope + Ad" icon

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@chickenn00dle chickenn00dle left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@github-actions github-actions Bot added [Status] Approved The pull request has been reviewed and is ready to merge and removed [Status] Needs Review The issue or pull request needs to be reviewed labels Mar 19, 2025
@thomasguillot thomasguillot merged commit 4698208 into epic/ia Mar 20, 2025
@thomasguillot thomasguillot deleted the update/ad-icons branch March 20, 2025 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Information Architecture [Status] Approved The pull request has been reviewed and is ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants