fix(ia): rerender subscription lists on esp provider update#3815
Merged
chickenn00dle merged 4 commits intoMar 18, 2025
Conversation
1d7ab90 to
02cd846
Compare
miguelpeixe
approved these changes
Mar 17, 2025
miguelpeixe
left a comment
Member
There was a problem hiding this comment.
Fixes the issue!
The whole lockedLists idea is not great (my bad) and the regex for provider key detection is a bit fragile. I don't think we should refactor this right now, though.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
Closes https://app.asana.com/1/26890605006346/project/1205919985867982/task/1209464932054166?focus=true
This PR fixes an issue where updating a provider does not always refresh the subscriptions lists associated with that provider until a page reload. This happened because subscriptions lists would rerender when the provider was updated, but before api credentials were stored and settings were saved. As a result updating the provider would cause the subscriptions lists to fetch using the outdated provider details.
We fix this by:
How to test the changes in this Pull Request:
Onboarding
reset newspacklink at the bottom of any wizardSwitching Providers
Bonus: Smoke test the ESP and Subscriptions Lists settings with invalid credentials, etc.
Other information: