Skip to content

Added rel="noopener noreferrer" to links with target="_blank" (P5: tests/ tools/)#9645

Closed
stevenlinx wants to merge 1 commit intoAutomattic:masterfrom
stevenlinx:i8128-p5
Closed

Added rel="noopener noreferrer" to links with target="_blank" (P5: tests/ tools/)#9645
stevenlinx wants to merge 1 commit intoAutomattic:masterfrom
stevenlinx:i8128-p5

Conversation

@stevenlinx
Copy link
Copy Markdown
Contributor

@stevenlinx stevenlinx commented May 25, 2018

Fixes #8128

@stevenlinx stevenlinx requested a review from a team as a code owner May 25, 2018 08:37
@oskosk oskosk added [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. and removed [Status] Needs Review This PR is ready for review. labels Jun 8, 2018
@oskosk
Copy link
Copy Markdown
Contributor

oskosk commented Jun 8, 2018 •
edited
Loading

@stevenlin-x thank you for your work on this... We're currently doing some file juggling that will be over in some days. I need to relabel this PR to "Needs author reply" because we really need testing instructions for each of the changes or they take us hours to reproduce a functional testing flow... I'll be watching these PRs in case you want to add the testing instructions. Otherwise It's gonna take me some time to write them so they get properly reviewed.

@abidhahmed abidhahmed mentioned this pull request Aug 8, 2018
Closed
@stale
Copy link
Copy Markdown

stale bot commented Sep 6, 2018

This PR has been marked as stale. This happened because:

  • It has been inactive in the past 3 months.
  • It hasn’t been labeled `[Pri] Blocker`, `[Pri] High`.

No further action is needed. But it's worth checking if this PR has clear testing instructions, is it up to date with master, and it is still valid. Feel free to close this issue if you think it's not valid anymore — if you do, please add a brief explanation.

@stale stale bot added the [Status] Stale label Sep 6, 2018
@kraftbj kraftbj closed this Apr 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

[Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. [Type] Janitorial Unit Tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add rel="noopener" to links with target="_blank"

5 participants

@stevenlinx @oskosk @kraftbj @jeherve @anomiex