Skip to content

Clean up first pass at user tracks API #9164

Merged
zinigor merged 2 commits intomasterfrom
revert/9003
Mar 27, 2018
Merged

Clean up first pass at user tracks API #9164
zinigor merged 2 commits intomasterfrom
revert/9003

Conversation

@dereksmart
Copy link
Copy Markdown
Contributor

@dereksmart dereksmart commented Mar 27, 2018

This reverts all of #9003
And any mention of the old jetpack_event_tracking setting that was registered for our settings API.

Do not merge until the UI has been updated to call the new endpoint in #9156

We're going with a more centralized API merged in #9142

Copy link
Copy Markdown
Contributor

@jaswrks jaswrks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

This is an important point that was made:

Do not merge until the UI has been updated to call the new endpoint in #9156

@mattwiebe
Copy link
Copy Markdown
Contributor

I merged #9156 so this is good to go

@zinigor zinigor added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Mar 27, 2018
Copy link
Copy Markdown
Contributor

@zinigor zinigor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverts the endpoint nicely, thanks!

@zinigor zinigor added this to the 6.0 milestone Mar 27, 2018
@zinigor zinigor merged commit 33b2f8d into master Mar 27, 2018
@ghost ghost removed the [Status] Ready to Merge Go ahead, you can push that green button! label Mar 27, 2018
@zinigor zinigor deleted the revert/9003 branch March 27, 2018 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants