Dashboard: fix undefined version number on footer#8395
Merged
Conversation
… undefined since data wasn't still available. This will now show Jetpack when the version is unavailable and the complete Jetpack version xx when it's available.
oskosk
approved these changes
Dec 20, 2017
Contributor
oskosk
left a comment
There was a problem hiding this comment.
LGTM!
Solves the issue.
Although I guess the root issue should be solved on the static side of things...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
undefinedsince data wasn't still available. This will now show Jetpack when the version is unavailable and the complete Jetpack version xx when it's available.Before
After
Testing instructions: