Skip to content

Update Goodreads URL for HTTPS support#8364

Merged
lancewillett merged 1 commit intomasterfrom
fix/goodreads-url-https
Dec 20, 2017
Merged

Update Goodreads URL for HTTPS support#8364
lancewillett merged 1 commit intomasterfrom
fix/goodreads-url-https

Conversation

@lancewillett
Copy link
Copy Markdown
Contributor

@lancewillett lancewillett commented Dec 14, 2017 •
edited by oskosk
Loading

See 7920-wpcom patch ready for commit on WP.com side.

Changes proposed in this Pull Request:

  • Update WP.com support link to support HTTPS
  • Update Goodreads URLs to support HTTPS

Testing instructions:

  • Add the widget to a sidebar, test with an author ID like 68367616 Author page
  • Test also with a normal, non-author user like 16499599 Lance

Proposed changelog entry for your changes:

Widgets: update Goodreads URL for HTTPS support

@lancewillett lancewillett requested a review from a team as a code owner December 14, 2017 21:51
oskosk
oskosk approved these changes Dec 20, 2017
View reviewed changes
Copy link
Copy Markdown
Contributor

@oskosk oskosk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oskosk oskosk added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Dec 20, 2017
@lancewillett lancewillett merged commit 92004a8 into master Dec 20, 2017
@oskosk oskosk deleted the fix/goodreads-url-https branch December 20, 2017 16:14
@oskosk oskosk added this to the 5.7 milestone Dec 20, 2017
@kraftbj kraftbj removed the [Status] Ready to Merge Go ahead, you can push that green button! label Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@oskosk oskosk oskosk approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

[Feature] Extra Sidebar Widgets Touches WP.com Files

Projects

None yet

Milestone

5.7

Development

Successfully merging this pull request may close these issues.

4 participants

@lancewillett @oskosk @kraftbj @matticbot