Skip to content

theme-option: Use esc_html__() in customize_register function. #8360

Merged
eliorivero merged 1 commit intoAutomattic:masterfrom
Umangvaghela:add_esc_html__
Dec 20, 2017
Merged

theme-option: Use esc_html__() in customize_register function. #8360
eliorivero merged 1 commit intoAutomattic:masterfrom
Umangvaghela:add_esc_html__

Conversation

@Umangvaghela
Copy link
Copy Markdown
Contributor

@Umangvaghela Umangvaghela commented Dec 14, 2017 •
edited
Loading

Changes proposed in this Pull Request:

  • I see many file customize_register() use esc_html__() instead of (). So it is fine to use esc_html() maintain consistency.

Testing instructions:

Proposed changelog entry for your changes:

@Umangvaghela Umangvaghela requested a review from a team as a code owner December 14, 2017 10:45
jeherve
jeherve approved these changes Dec 14, 2017
View reviewed changes
Copy link
Copy Markdown
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jeherve jeherve added the [Status] Ready to Merge Go ahead, you can push that green button! label Dec 14, 2017
@eliorivero eliorivero merged commit 27a9e61 into Automattic:master Dec 20, 2017
@oskosk oskosk added this to the 5.7 milestone Dec 20, 2017
@kraftbj kraftbj removed the [Status] Ready to Merge Go ahead, you can push that green button! label Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jeherve jeherve jeherve approved these changes

Assignees

No one assigned

Labels

[Feature] Theme Tools [Pri] Low Touches WP.com Files [Type] Janitorial

Projects

None yet

Milestone

5.7

Development

Successfully merging this pull request may close these issues.

6 participants

@Umangvaghela @jeherve @kraftbj @oskosk @eliorivero @matticbot