Skip to content

Comments: sync comment endpoint with dotcom#8346

Merged
oskosk merged 2 commits intomasterfrom
update/sync-comments-endpoint
Dec 20, 2017
Merged

Comments: sync comment endpoint with dotcom#8346
oskosk merged 2 commits intomasterfrom
update/sync-comments-endpoint

Conversation

@vindl
Copy link
Copy Markdown
Member

@vindl vindl commented Dec 12, 2017

Syncing code with latest changes introduced in D8703-code.

Copy link
Copy Markdown
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick review for coding standards

);
break;
case 'can_moderate':
$response[$key] = (bool) current_user_can( 'edit_comment', $comment_id );
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you missed spaces inside the square brackets. Could you add them?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, updated in 865d89a.

@jeherve jeherve added [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. and removed [Status] Needs Review This PR is ready for review. labels Dec 12, 2017
@vindl vindl added [Status] Needs Review This PR is ready for review. and removed [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. labels Dec 13, 2017
@vindl vindl requested a review from a team December 13, 2017 20:58
Copy link
Copy Markdown
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Dec 13, 2017
Copy link
Copy Markdown
Contributor

@oskosk oskosk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oskosk oskosk merged commit 23debd3 into master Dec 20, 2017
@oskosk oskosk deleted the update/sync-comments-endpoint branch December 20, 2017 16:01
@vindl vindl removed the [Status] Ready to Merge Go ahead, you can push that green button! label Dec 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants