Skip to content

Add revisions to Portfolios#8307

Merged
oskosk merged 1 commit intomasterfrom
add/revisions-for-portfolios
Dec 20, 2017
Merged

Add revisions to Portfolios#8307
oskosk merged 1 commit intomasterfrom
add/revisions-for-portfolios

Conversation

@marekhrabe
Copy link
Copy Markdown
Contributor

@marekhrabe marekhrabe commented Dec 5, 2017

Changes proposed in this Pull Request:

  • enables revisions for jetpack-portfolio post type
  • ensures feature parity with r120738-wpcom which is in place for 2 years already

Testing instructions:

  • make a new post with post type jetpack-revisions
  • save the draft few times
  • confirm you can see revisions in the sidebar, just as you would see for posts or pages

Proposed changelog entry for your changes:

Added ability to create revisions of Portfolio Projects.

@marekhrabe marekhrabe requested a review from a team as a code owner December 5, 2017 13:55
@marekhrabe marekhrabe added the [Status] Needs Review This PR is ready for review. label Dec 5, 2017
@jeherve jeherve added [Feature] Custom Content Types Custom post or content types (usually for testimonials and portfolios) and their settings. [Status] Tested on WP.com [Pri] Normal labels Dec 5, 2017
jeherve
jeherve approved these changes Dec 5, 2017
View reviewed changes
Copy link
Copy Markdown
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Dec 5, 2017
@marekhrabe
Copy link
Copy Markdown
Contributor Author

marekhrabe commented Dec 6, 2017

@jeherve Do you have any context for the failing tests? I'm not a good PHP dev and never worked with Travis but those errors seem to be unrelated to this PR.

@jeherve
Copy link
Copy Markdown
Member

jeherve commented Dec 6, 2017

Yup, they are safe to ignore. I just relaunched the tests, things should be okay. Someone else from the Jetpack team will then make sure to take a look and merge that PR before the next release.

oskosk
oskosk approved these changes Dec 20, 2017
View reviewed changes
Copy link
Copy Markdown
Contributor

@oskosk oskosk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@oskosk oskosk merged commit a6db31f into master Dec 20, 2017
@oskosk oskosk deleted the add/revisions-for-portfolios branch December 20, 2017 17:33
@oskosk oskosk added this to the 5.7 milestone Dec 20, 2017
@kraftbj kraftbj removed the [Status] Ready to Merge Go ahead, you can push that green button! label Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jeherve jeherve jeherve approved these changes

+1 more reviewer

@oskosk oskosk oskosk approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

[Feature] Custom Content Types Custom post or content types (usually for testimonials and portfolios) and their settings. [Pri] Normal [Status] Tested on WP.com Touches WP.com Files

Projects

None yet

Milestone

5.7

Development

Successfully merging this pull request may close these issues.

5 participants

@marekhrabe @jeherve @oskosk @kraftbj @matticbot