Admin Page: Hide Masterbar toggle for Atomic Sites#8290
Conversation
|
Also cc @dereksmart |
|
After some more thought, instead of disabling the toggle I think it would be even better if we removed the card completely. |
I would agree. |
|
Self-note: Maybe it would be best to check if the available module is there instead of checking for atomic site. |
|
@MichaelArestad what do you think about this ? |
|
I was just having this conversation in parallel with other folks. I would remove the Masterbar card altogether for now unless @apeatling has any objections. |
We should be able to keep all the changes contained in this file by bailing early in render: or |
a3ab14f to
ff3b450
Compare
ff3b450 to
aa370a9
Compare
|
Thanks for the feedback folks. I've addressed the requested changes. Will check in an Atomic site when the PR is available in Jetpack Beta Plugin. Merging afterwards if everything's ok! |
|
Thanks @vindl . I've just checked in an Atomic Site. Merging now! |
Users of Atomic sites are currently seeing this toggle and being able to interact with it. This results in a weird experience when they try to deactivate the Masterbar as the toggle ends up moving, the page refreshing and the masterbar stays active.
Changes proposed in this Pull Request:
Testing instructions:
Screenshot
Proposed changelog entry for your changes:
Hide the Master bar settings card for Atomic Sites.