JITM: Fix JITM display when the first result has been dismissed.#8245
Merged
JITM: Fix JITM display when the first result has been dismissed.#8245
Conversation
Contributor
Author
|
@withinboredom any chance to look at this?.. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On a page where two JITMs exist, but the first has been dismissed, the response back from the API here will be an object with a key of
1:...instead of the zero-indexed array expected in the code handling the response, giving an uncaught type error (and no JITM displayed).
This PR hacks Humpty back together again, but I'm not sure how better to handle it. It seems we should be leaving the response coming from the API alone, to keep open the possibility of handling multiple JITMs on the client in the future. This PR also doesn't take into account any other variations that may creep in to the client somehow. I'm also unclear as to how dismissals are handled, or where the variation between the return of
get_jitm()on the server side (an array with two values) and the client-side response (object with only one value) happens.Any suggestions @withinboredom ?