Skip to content

Admin Page: Apply codemod for prop-types#8158

Merged
dereksmart merged 2 commits intomasterfrom
update/prop-types
Nov 27, 2017
Merged

Admin Page: Apply codemod for prop-types#8158
dereksmart merged 2 commits intomasterfrom
update/prop-types

Conversation

@oskosk
Copy link
Copy Markdown
Contributor

@oskosk oskosk commented Nov 14, 2017 •
edited
Loading

Part of #8159 .

Fixes warnings in console and while building.

Changes proposed in this Pull Request:

  • Changes every occurrence of imports of PropTypes coming from React, to come from the module prop-types.
  • Adds prop-types package as dependency.

Testing instructions:

  • Build the Admin Page.
  • Confirm it builds well.
  • Visit the admin page. Confirm it's there.

@oskosk oskosk added [Status] Needs Review This PR is ready for review. [Type] Janitorial labels Nov 14, 2017
@oskosk oskosk requested a review from a team as a code owner November 14, 2017 14:51
@oskosk oskosk mentioned this pull request Nov 14, 2017
Closed
8 tasks
@oskosk oskosk added this to the 5.6 milestone Nov 14, 2017
@oskosk oskosk requested review from dereksmart and zinigor November 14, 2017 17:20
@oskosk oskosk mentioned this pull request Nov 17, 2017
Merged
@eliorivero
Copy link
Copy Markdown
Contributor

eliorivero commented Nov 17, 2017

I still see

Warning: Accessing PropTypes via the main React package is deprecated, and will be removed in  React v16.0. Use the latest available v15.* prop-types package from npm instead. For info on usage, compatibility, migration and more, see https://fb.me/prop-types-docs

and I think it's not coming from this, but dops-components instead like in https://github.com/Automattic/dops-components/blob/master/client/components/foldable-card/index.jsx#L20

@oskosk
Copy link
Copy Markdown
Contributor Author

oskosk commented Nov 17, 2017 •
edited
Loading

Yes @eliorivero , this is coming from dops-components certainly. I'm gonna address that in that repo I think

dereksmart
dereksmart approved these changes Nov 27, 2017
View reviewed changes
Copy link
Copy Markdown
Contributor

@dereksmart dereksmart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests well, other than the dops-components stuff Elio mentioned

@dereksmart dereksmart added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Nov 27, 2017
@dereksmart dereksmart merged commit 6605748 into master Nov 27, 2017
@dereksmart dereksmart deleted the update/prop-types branch November 27, 2017 17:13
@dereksmart dereksmart removed the [Status] Ready to Merge Go ahead, you can push that green button! label Nov 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dereksmart dereksmart dereksmart approved these changes

@zinigor zinigor Awaiting requested review from zinigor

Assignees

No one assigned

Labels

[Type] Janitorial

Projects

None yet

Milestone

5.6

Development

Successfully merging this pull request may close these issues.

3 participants

@oskosk @eliorivero @dereksmart