Skip to content

CLI: Do not change directory within partner scripts#8009

Merged
ebinnion merged 1 commit intomasterfrom
fix/partner-provision-cd
Oct 18, 2017
Merged

CLI: Do not change directory within partner scripts#8009
ebinnion merged 1 commit intomasterfrom
fix/partner-provision-cd

Conversation

@ebinnion
Copy link
Copy Markdown
Contributor

To provide flexibility in implementation, let's not assume where we need to change directory to.

This came up in my testing of JPS v2 where I had symlinked my Jetpack directory to another copy of Jetpack in another WordPress installation. I was able to get around this by going one directory up and running the partner provision script.

By removing the cd command going one directory above jetapck to wp-content/plugins I was able to get the script to successfully run.

To test:

  • Check out branch
  • Run sh jetpack/bin/partner-provision.sh --partner_id={$id} --partner_secret={$secret} --plan={$plan} --url={$url} --user=1 with proper variables. See @gravityrail or @ebinnion for details
  • Ensure next_url returned in response is a proper authorization URL

@ebinnion ebinnion added [Feature] Jetpack CLI Bug When a feature is broken and / or not performing as intended labels Oct 17, 2017
@ebinnion ebinnion added this to the 5.5 milestone Oct 17, 2017
@ebinnion ebinnion self-assigned this Oct 17, 2017
@ebinnion ebinnion requested a review from a team as a code owner October 17, 2017 22:13
@ebinnion ebinnion requested a review from gravityrail October 17, 2017 22:16
@jeherve jeherve added [Pri] High [Status] Needs Review This PR is ready for review. labels Oct 18, 2017
Copy link
Copy Markdown
Contributor

@oskosk oskosk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks fine!

@ebinnion ebinnion merged commit 441289e into master Oct 18, 2017
@ebinnion ebinnion deleted the fix/partner-provision-cd branch October 18, 2017 21:54
@ebinnion ebinnion removed the [Status] Needs Review This PR is ready for review. label Oct 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug When a feature is broken and / or not performing as intended [Feature] Jetpack CLI [Pri] High

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants