CLI: Do not change directory within partner scripts#8009
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To provide flexibility in implementation, let's not assume where we need to change directory to.
This came up in my testing of JPS v2 where I had symlinked my Jetpack directory to another copy of Jetpack in another WordPress installation. I was able to get around this by going one directory up and running the partner provision script.
By removing the
cdcommand going one directory abovejetapcktowp-content/pluginsI was able to get the script to successfully run.To test:
sh jetpack/bin/partner-provision.sh --partner_id={$id} --partner_secret={$secret} --plan={$plan} --url={$url} --user=1with proper variables. See @gravityrail or @ebinnion for detailsnext_urlreturned in response is a proper authorization URL