Switch Travis CI environment to Trusty - PHP 5.2 to be no longer available Sept 2017#7453
Merged
kraftbj merged 2 commits intoAutomattic:masterfrom Jul 19, 2017
ntwb:patch-1
Merged
Switch Travis CI environment to Trusty - PHP 5.2 to be no longer available Sept 2017#7453kraftbj merged 2 commits intoAutomattic:masterfrom ntwb:patch-1
kraftbj merged 2 commits intoAutomattic:masterfrom
ntwb:patch-1
Conversation
Contributor
Author
|
PHP 5.3 is also affected! Issue and PR updated |
Contributor
Author
|
There's unrelated PHPunit tests causing the failures here of this PR: There was 1 failure:
1) WP_Test_Grunion_Contact_Form::test_parse_contact_field_escapes_things_inside_a_value_and_attribute_and_the_content
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'[contact-field label='Name' type='name' required='1'/][contact-field label='Email' type=''email'' req'uired='1'/][contact-field label='asdasd' type='text'/][contact-field id='1' required 'derp' herp asd lkj]adsasd[/contact-field]'
+'[contact-field label='Name' type='name' required='1'/][contact-field label='Email' type=''email'' req'uired='1'/][contact-field label='asdasd' type='text'/][contact-field id='1' required derp herp asd lkj]adsasd[/contact-field]'
/tmp/wordpress-master/src/wp-content/plugins/jetpack/tests/php/modules/contact-form/test_class.grunion-contact-form.php:536
FAILURES!
Tests: 959, Assertions: 2231, Failures: 1, Skipped: 24, Incomplete: 12. |
Contributor
|
Unrelated PHP unit tests should be fixed now, re-running the tests |
Contributor
Author
|
FYI: Travis CI have not specified any order of migration, these changes could affect Jetpack anytime now |
kraftbj
approved these changes
Jul 19, 2017
Contributor
|
Going to merge this in to confirm this resolves the issue we're seeing in new PRs :) (Merging out of process only since it is a unit test issue, not production code). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Via #WP41292
Travis CI have announced they are switching to Trusty as the default distro come July 18th 2017
The current availability of PHP 5.2 & 5.3 in the Travis CI build environment is the following:
dist: precisewithsudo: falsedist: trustywithsudo: falsedist: precisewithsudo: falsedist: precisewithsudo: requiredJetpack's current Travis CI config uses option
1aboveTravis CI will override this configuration with option
2come July 18th 2017Workaround to use PHP 5.2 & 5.3 until September 2017 using option
3for the PHP 5.2 & 5.3 Travis CI jobCome September 2017 Travis CI will overwrite option
3above with option4I've created the following Travis CI issue on the subject: travis-ci/travis-ci#8072