Removed old publicize endpoints that are no longer used.#7221
Merged
zinigor merged 1 commit intofeature/sync-json-endpointsfrom May 23, 2017
Merged
Removed old publicize endpoints that are no longer used.#7221zinigor merged 1 commit intofeature/sync-json-endpointsfrom
zinigor merged 1 commit intofeature/sync-json-endpointsfrom
Conversation
aduth
approved these changes
May 23, 2017
Member
aduth
left a comment
There was a problem hiding this comment.
I'm not so much familiar with the publicize:new endpoint, but seems reasonable to remove the endpoints classes given they're not used or instantiated anywhere and are forced to occur on WPCOM.
Contributor
|
I agree with @aduth |
lezama
approved these changes
May 23, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
Note: the
WPCOM_JSON_API_Publicize_Endpointclass instantiation code is removed because it is only available on dotcom side.cc @lezama, @retrofox, @aduth please take a look - I'm pretty sure none of the current Publicize management code paths use these classes.