Sync the list media endpoint.#7022
Merged
zinigor merged 3 commits intofeature/sync-json-endpointsfrom Apr 23, 2017
Merged
Conversation
…ssification images When search media library, inject in the extra images from classification. These will show in Media Library when on Calypso branch: a8cgm/image-classify Added hide-in-jetpack block and limits to blogs specified in UIC class Merges r142462-wpcom.
Media Library was only showing 20 images due to an off count error. The pagination used a different value than what we modified. Bugs reports: https://en.[private link]?replies=39 https://help.automattic.com/staff/index.php?_m=tickets&_a=viewticket&ticketid=2839143&departmentid=41&ticketstatusid=5 Merges r142545-wpcom.
19 tasks
Contributor
Author
|
Master issue: #7026 |
jeherve
approved these changes
Apr 23, 2017
Member
jeherve
left a comment
There was a problem hiding this comment.
This should be good to merge!
Contributor
|
Sorry, I missed the ping last week, so I'm late to this change but we do not need the image classification code, it is not being used and stuck around much longer than necessary. Do you want me to remove it from WPCOM and then it can sync to here? |
Member
That sounds good. It's not used in Jetpack anyway, but if we don't use it on wpcom either it's probably best to clean things up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because an associative array can be converted to an object, ensure that we only return the array values and not keys.
Merges r135464-wpcom.