Sync get post endpoints.#7006
Merged
zinigor merged 3 commits intofeature/sync-json-endpointsfrom Apr 21, 2017
Merged
Conversation
Merges r138390-wpcom.
Currently load_theme_functions is not being called when a post's type is "page". This is resulting in the post_tag taxonomy not being registered as a post type on themes that support tags for pages. https://[private link] Merges r142741-wpcom.
In r142741 I enabled load_theme_functions for type=page. Today we had a report of issues with the page listing in calypso for the Portfolio theme. Confirmed the regression was introduced with the loading of theme functions so am backing out that change to investigate further. https://[private link] Merges r143168-wpcom.
timmyc
previously requested changes
Apr 20, 2017
|
|
||
| if ( isset( $args['type'] ) && | ||
| ! in_array( $args['type'], array( 'post', 'page', 'revision', 'any' ) ) && | ||
| ! in_array( $args['type'], array( 'post', 'revision', 'page', 'any' ) ) && |
Contributor
There was a problem hiding this comment.
this appears to be a bit different then my original wpcom PR, that merge involved removing page from these arrays, so this line was:
! in_array( $args['type'], array( 'post', 'revision', 'any' ) ) &&
See 5b6081f
19 tasks
Contributor
Author
|
Master issue: #7026 |
We have agreed that the change is correct, no fix needed at this time.
Contributor
|
Thanks for helping me remember my revert there @zinigor - and for getting these changes to JP. 🙌 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings code between dotcom and Jetpack in sync for several endpoints.