Settings UI: Adds sharing tab with cards for individual sharing services.#6750
Merged
dereksmart merged 7 commits intofeature/settings-overhaulfrom Mar 24, 2017
Merged
Settings UI: Adds sharing tab with cards for individual sharing services.#6750dereksmart merged 7 commits intofeature/settings-overhaulfrom
dereksmart merged 7 commits intofeature/settings-overhaulfrom
Conversation
It has three sub-modules: publicize, sharing, and likes. Likes is the only one with actual settings. The others will link to wordpress.com to either configure settings there, or link the user account if not linked.
|
Can the tab be between writing and discussion? Otherwise looks awesome. |
Contributor
Author
|
Moved the tab, and also fixed so that editors will have access to the publicize card. |
Contributor
|
Got errors on |
eliorivero
reviewed
Mar 24, 2017
| </SettingsCard> | ||
| ); | ||
| } | ||
| } No newline at end of file |
Contributor
|
Good to go! |
…ese tests were no longer useful
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #6745
This adds a new route/tab for
/sharingUsers who are linked should be taken to wordpress.com/sharing settings area, where unlinked users should see cards asking them to connect their user account.