Skip to content

Settings UI: fix disconnection dialog latency#6749

Merged
dereksmart merged 1 commit intofeature/settings-overhaulfrom
fix/disconnection-dialog-latency
Mar 24, 2017
Merged

Settings UI: fix disconnection dialog latency#6749
dereksmart merged 1 commit intofeature/settings-overhaulfrom
fix/disconnection-dialog-latency

Conversation

@eliorivero
Copy link
Copy Markdown
Contributor

@eliorivero eliorivero commented Mar 24, 2017

Changes proposed in this Pull Request:

  • don't initiate a new site data query since there's already one started by AtAGlance component where disconnection dialog lives. This solves the issue of feature text replaced after the site data is received

Testing instructions:

  • verify that when disconnection dialog opens, the text about features is not quickly replaced

@eliorivero
Settings UI: don't initiate a new site data query since there's alrea…
705cec3 
…dy one started by AtAGlance component where disconnection dialog lives. This solves the issue of feature text replaced after the site data is received
@eliorivero eliorivero added Admin Page React-powered dashboard under the Jetpack menu [Status] Needs Review This PR is ready for review. Bug When a feature is broken and / or not performing as intended labels Mar 24, 2017
@eliorivero eliorivero added this to the Settings UI milestone Mar 24, 2017
@eliorivero eliorivero self-assigned this Mar 24, 2017
@eliorivero eliorivero requested a review from dereksmart March 24, 2017 19:46
dereksmart
dereksmart approved these changes Mar 24, 2017
View reviewed changes
Copy link
Copy Markdown
Contributor

@dereksmart dereksmart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup!

@dereksmart dereksmart added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Mar 24, 2017
@dereksmart dereksmart merged commit 6007d3a into feature/settings-overhaul Mar 24, 2017
@dereksmart dereksmart deleted the fix/disconnection-dialog-latency branch March 24, 2017 21:20
@dereksmart dereksmart removed the [Status] Ready to Merge Go ahead, you can push that green button! label Mar 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dereksmart dereksmart dereksmart approved these changes

Assignees

@eliorivero eliorivero

Labels

Admin Page React-powered dashboard under the Jetpack menu Bug When a feature is broken and / or not performing as intended

Projects

None yet

Milestone

Settings UI

Development

Successfully merging this pull request may close these issues.

2 participants

@eliorivero @dereksmart