Skip to content

Settings UI: new card for Sitemaps#6746

Merged
dereksmart merged 2 commits intofeature/settings-overhaulfrom
update/new-card-sitemaps
Mar 24, 2017
Merged

Settings UI: new card for Sitemaps#6746
dereksmart merged 2 commits intofeature/settings-overhaulfrom
update/new-card-sitemaps

Conversation

@eliorivero
Copy link
Copy Markdown
Contributor

@eliorivero eliorivero commented Mar 24, 2017 •
edited
Loading

Changes proposed in this Pull Request:

  • Sitemaps now has its own card
  • card is above Site Verification as per p1HpG7-3Sm-jetpackp2
  • setting explanation is indented below toggle

captura de pantalla 2017-03-24 a las 15 23 14

captura de pantalla 2017-03-24 a las 17 47 52

Testing instructions:

  • render and assert that Sitemaps is in a new card above Site Verification

Proposed changelog entry for your changes:

@eliorivero eliorivero added Admin Page React-powered dashboard under the Jetpack menu [Status] Needs Review This PR is ready for review. Enhancement Changes to an existing feature — removing, adding, or changing parts of it labels Mar 24, 2017
@eliorivero eliorivero added this to the Settings UI milestone Mar 24, 2017
@eliorivero eliorivero self-assigned this Mar 24, 2017
@rickybanister
Copy link
Copy Markdown

rickybanister commented Mar 24, 2017

There seems to be extra margin or padding below the links in the card—the bottom padding should match the card above.

@eliorivero eliorivero force-pushed the update/new-card-sitemaps branch from dbeb593 to 2b17ca7 Compare March 24, 2017 20:47
@eliorivero
Copy link
Copy Markdown
Contributor Author

eliorivero commented Mar 24, 2017

Fixed. I've updated the screenshot.

dereksmart
dereksmart approved these changes Mar 24, 2017
View reviewed changes
Copy link
Copy Markdown
Contributor

@dereksmart dereksmart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dereksmart dereksmart added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Mar 24, 2017
@dereksmart dereksmart merged commit 4e6b487 into feature/settings-overhaul Mar 24, 2017
@dereksmart dereksmart deleted the update/new-card-sitemaps branch March 24, 2017 21:26
@dereksmart dereksmart removed the [Status] Ready to Merge Go ahead, you can push that green button! label Mar 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dereksmart dereksmart dereksmart approved these changes

@MichaelArestad MichaelArestad Awaiting requested review from MichaelArestad

@rickybanister rickybanister Awaiting requested review from rickybanister

Assignees

@eliorivero eliorivero

Labels

Admin Page React-powered dashboard under the Jetpack menu Enhancement Changes to an existing feature — removing, adding, or changing parts of it

Projects

None yet

Milestone

Settings UI

Development

Successfully merging this pull request may close these issues.

3 participants

@eliorivero @rickybanister @dereksmart