Settings UI: Refactor ProStatus component to be more DRY and readable#6739
Merged
eliorivero merged 2 commits intofeature/settings-overhaulfrom Mar 24, 2017
Merged
Settings UI: Refactor ProStatus component to be more DRY and readable#6739eliorivero merged 2 commits intofeature/settings-overhaulfrom
eliorivero merged 2 commits intofeature/settings-overhaulfrom
Conversation
Contributor
|
I put my site in a free plan and I still see the "Secure" badge in Scan settings card:
|
Contributor
Author
|
@eliorivero becuase you have vp installed and active probably. Remember that it's possible someone has VaultPress without a plan. |
eliorivero
reviewed
Mar 24, 2017
_inc/client/pro-status/index.jsx
Outdated
| if ( this.props.fetchingSiteData ) { | ||
| return ''; | ||
| const akismetData = this.props.getAkismetData(); | ||
| if ( 'invalid_key' === akismetData ) { |
Contributor
There was a problem hiding this comment.
This should use isAkismetKeyValid() since it returns only the data necessary for key validation. getAkismetData() returns all the data for prevented spam and it's a larger amount of data.
Contributor
|
Ok, it works when VP is inactive and the SET UP button takes me to VP setup. |
…ompt when installed & active.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This component because pretty convoluted.
It also fixes inconsistencies with the Akismet card in the dashboard. Now we are showing the same
upgradenotice that we use for scans instead of the button. It also links theinvalid keynotice to an actual URL. Before it wasn't.To test:
set upin the scan card within /security when it's not set up on a paid plan.