Reverted part of the changes introduced in #6339.#6649
Merged
eliorivero merged 1 commit intomasterfrom Mar 14, 2017
Merged
Conversation
Contributor
Author
|
Partially borrows from #6641 |
jeherve
approved these changes
Mar 14, 2017
Member
jeherve
left a comment
There was a problem hiding this comment.
This should be good to merge! 🚢
Contributor
|
It's good. Will merge once Travis ends. |
eliorivero
approved these changes
Mar 14, 2017
Contributor
Contributor
|
in branch-4.7 c813ec2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6640
Changes proposed in this Pull Request:
display_footermethod of sharing service classes immediately instead of delegating to a later hook.Testing instructions: