Conversation
3rd-party/woocommerce-services.php
Outdated
| */ | ||
| private function install() { | ||
| $jetpack = Jetpack::init(); | ||
| $jetpack->stat( 'jitm', 'wooservices-activated-' . JETPACK__VERSION ); |
There was a problem hiding this comment.
Would it make sense to move this below (after success), so we're not tracking failed attempts?
There was a problem hiding this comment.
I'd rather track an additional stat to determine successful install.. as it sits, we should be able to glean that people are having installation problems by comparing the number of activated stats to active sites.. though that method isn't without it's flaws.
What do you think about tracking an install stat on button click, and an activated stat on successful result of the install() method?
There was a problem hiding this comment.
What do you think about tracking an install stat on button click, and an activated stat on successful result of the install() method?
|
merged to 4.6 20adafb |
Changes proposed in this Pull Request:
woocommerce_servicesMC stat towooservices(was hitting char limit)launchtype, record as module activationTesting instructions:
wooservicesgroup, and thatjitmActionToTakeis notlaunchfor WooCommerce Services.Proposed changelog entry for your changes: