Skip to content

Settings UI: remove notices after 2 secs#6285

Merged
eliorivero merged 2 commits intofeature/settings-overhaulfrom
update/remove-notices-after-x-secs
Feb 3, 2017
Merged

Settings UI: remove notices after 2 secs#6285
eliorivero merged 2 commits intofeature/settings-overhaulfrom
update/remove-notices-after-x-secs

Conversation

@eliorivero
Copy link
Copy Markdown
Contributor

@eliorivero eliorivero commented Feb 3, 2017 •
edited
Loading

Fixes #6204

Changes proposed in this Pull Request:

  • remove updated settings notice after 2 seconds
  • refactor updateSettings action to consider when Post by Email address is regenerated. This allows to remove a large portion of code that is basically the same with only a few tweaks for PbE.

autohide

Testing instructions:

  • build and save or toggle options. The Updated settings notice should dissapear after 2 seconds.
  • regenerate Post by Email address. The notice text should be different.

@eliorivero
Settings UI: remove updated settings notice after 2 seconds, fixes #6204
92e07f1
@eliorivero
Settings UI: refactor updateSettings action to consolidate it with ex…
621d64c 
…tra one defined for Post by Email address and remove a large portion of otherwise duplicated code.
@eliorivero eliorivero added Admin Page React-powered dashboard under the Jetpack menu [Status] Needs Review This PR is ready for review. Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Type] Janitorial labels Feb 3, 2017
@eliorivero eliorivero added this to the Settings UI milestone Feb 3, 2017
@eliorivero eliorivero self-assigned this Feb 3, 2017
@MichaelArestad
Copy link
Copy Markdown
Contributor

MichaelArestad commented Feb 3, 2017

LGTM

@MichaelArestad MichaelArestad added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Feb 3, 2017
@eliorivero eliorivero merged commit a958c6c into feature/settings-overhaul Feb 3, 2017
@eliorivero eliorivero deleted the update/remove-notices-after-x-secs branch February 3, 2017 19:00
@eliorivero eliorivero mentioned this pull request Feb 3, 2017
Closed
@kraftbj kraftbj removed the [Status] Ready to Merge Go ahead, you can push that green button! label Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@eliorivero eliorivero

Labels

Admin Page React-powered dashboard under the Jetpack menu Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Type] Janitorial

Projects

None yet

Milestone

Settings UI

Development

Successfully merging this pull request may close these issues.

3 participants

@eliorivero @MichaelArestad @kraftbj