Skip to content

Settings UI: add a link to Sharing in settings navigation#6274

Merged
eliorivero merged 2 commits intofeature/settings-overhaulfrom
add/sharing-link-settings-nav
Feb 3, 2017
Merged

Settings UI: add a link to Sharing in settings navigation#6274
eliorivero merged 2 commits intofeature/settings-overhaulfrom
add/sharing-link-settings-nav

Conversation

@eliorivero
Copy link
Copy Markdown
Contributor

@eliorivero eliorivero commented Feb 2, 2017

Fixes #6228

Changes proposed in this Pull Request:

  • adds a Sharing link with icon to the Settings navigation bar:
    • if site is connected, it goes to Sharing section in Calypso
    • if site isn't connected, it goes to Settings > Sharing in WP Admin.
  • the link is displayed if Publicize or Sharing modules are active

Testing instructions:

  • build and make sure the link goes to the correct location when site it's connected and when it's in dev mode.

@eliorivero eliorivero added Admin Page React-powered dashboard under the Jetpack menu [Status] Needs Review This PR is ready for review. labels Feb 2, 2017
@eliorivero eliorivero added this to the Settings UI milestone Feb 2, 2017
@eliorivero eliorivero self-assigned this Feb 2, 2017
@beaulebens
Copy link
Copy Markdown
Member

beaulebens commented Feb 2, 2017

This is working/LGTM. I'm not sure why Travis is saying a check failed.

I think we probably don't need the external icon to show when in dev mode (linking to local wp-admin page).

@eliorivero
Settings UI: update Sharing link to not display icon when it goes to …
fa6f178 
…WP Admin. Added new tests for Sharing and updated the one that was failing.
@eliorivero
Copy link
Copy Markdown
Contributor Author

eliorivero commented Feb 3, 2017

Icon is now not visible when it's linked to WP Admin. Fixed test that was failing and added more for Sharing link and icon.

@eliorivero eliorivero merged commit 234a10c into feature/settings-overhaul Feb 3, 2017
@eliorivero eliorivero deleted the add/sharing-link-settings-nav branch February 3, 2017 20:11
@eliorivero eliorivero removed the [Status] Needs Review This PR is ready for review. label Feb 3, 2017
@eliorivero eliorivero mentioned this pull request Feb 3, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MichaelArestad MichaelArestad Awaiting requested review from MichaelArestad

Assignees

@eliorivero eliorivero

Labels

Admin Page React-powered dashboard under the Jetpack menu

Projects

None yet

Milestone

Settings UI

Development

Successfully merging this pull request may close these issues.

2 participants

@eliorivero @beaulebens