Skip to content

Updated design of brute force protection settings group#6271

Merged
MichaelArestad merged 1 commit intofeature/settings-overhaulfrom
update/brute-force-settings
Feb 3, 2017
Merged

Updated design of brute force protection settings group#6271
MichaelArestad merged 1 commit intofeature/settings-overhaulfrom
update/brute-force-settings

Conversation

@MichaelArestad
Copy link
Copy Markdown
Contributor

@MichaelArestad MichaelArestad commented Feb 2, 2017

Changes proposed in this Pull Request:

  • removed redundant explanation text
  • made IP a label
  • embiggened Add to whitelist button

Testing instructions:

  • switch to branch
  • take a good look at the Brute force protection group in Security settings

Before

image

After

image

@MichaelArestad MichaelArestad added [Status] Needs Design Review Design has been added. Needs a review! [Status] Needs Review This PR is ready for review. Enhancement Changes to an existing feature — removing, adding, or changing parts of it labels Feb 2, 2017
@MichaelArestad MichaelArestad self-assigned this Feb 2, 2017
@ashleighaxios
Copy link
Copy Markdown
Contributor

ashleighaxios commented Feb 2, 2017

Taking a look

@jeherve jeherve added this to the Settings UI milestone Feb 3, 2017
eliorivero
eliorivero approved these changes Feb 3, 2017
View reviewed changes
Copy link
Copy Markdown
Contributor

@eliorivero eliorivero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐑

@eliorivero eliorivero added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Feb 3, 2017
@ashleighaxios
Copy link
Copy Markdown
Contributor

ashleighaxios commented Feb 3, 2017

Design reviewed. Looks solid!

@ashleighaxios ashleighaxios removed the [Status] Needs Design Review Design has been added. Needs a review! label Feb 3, 2017
@MichaelArestad MichaelArestad merged commit a098fc0 into feature/settings-overhaul Feb 3, 2017
@MichaelArestad MichaelArestad deleted the update/brute-force-settings branch February 3, 2017 20:26
@matticbot matticbot removed the [Status] Ready to Merge Go ahead, you can push that green button! label Feb 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jeffgolenski jeffgolenski Awaiting requested review from jeffgolenski

@ashleighaxios ashleighaxios Awaiting requested review from ashleighaxios

1 more reviewer

@eliorivero eliorivero eliorivero approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@MichaelArestad MichaelArestad

Labels

Enhancement Changes to an existing feature — removing, adding, or changing parts of it

Projects

None yet

Milestone

Settings UI

Development

Successfully merging this pull request may close these issues.

5 participants

@MichaelArestad @ashleighaxios @eliorivero @jeherve @matticbot