Skip to content

Tracks: don't allow Travis CI/unit tests to fire tracks events #6266

Merged
eliorivero merged 1 commit intomasterfrom
fix/stop-tracks-for-unit-tests
Feb 2, 2017
Merged

Tracks: don't allow Travis CI/unit tests to fire tracks events #6266
eliorivero merged 1 commit intomasterfrom
fix/stop-tracks-for-unit-tests

Conversation

@dereksmart
Copy link
Copy Markdown
Contributor

#6248 was generating a tracks event for every travis test. Let's put a stop to sending events for automated testing.

To Test:

  • Put some error_logging below the changeset here.
  • run phpunit --testsuite "restapi"
  • No logs should appear, nor tracks.

This doesn't necessarily have to go into 4.6, but it should go into master to stop the fake events from being fired on builds.

@dereksmart dereksmart added the [Status] Needs Review This PR is ready for review. label Feb 2, 2017
@dereksmart dereksmart added this to the 2/17 - February milestone Feb 2, 2017
@dereksmart dereksmart requested a review from eliorivero February 2, 2017 16:17
@roccotripaldi roccotripaldi self-requested a review February 2, 2017 16:22
Copy link
Copy Markdown
Contributor

@roccotripaldi roccotripaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Good catch!

@eliorivero
Copy link
Copy Markdown
Contributor

Works fine! 🐑

@eliorivero eliorivero added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Feb 2, 2017
@eliorivero eliorivero merged commit b7ff305 into master Feb 2, 2017
@eliorivero eliorivero deleted the fix/stop-tracks-for-unit-tests branch February 2, 2017 16:33
@kraftbj kraftbj removed the [Status] Ready to Merge Go ahead, you can push that green button! label Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants