Replace 'types' with 'type'#6261
Conversation
|
The types=>type change looks good, but I think the module headings changes "conflict" with #6258. |
|
@beaulebens They do, but we can figure it out. |
| <span className="jp-form-toggle-explanation"> | ||
| { | ||
| __( 'Enable Portfolio custom content types.' ) | ||
| __( 'Enable Portfolio custom content type.' ) |
There was a problem hiding this comment.
These periods should be removed.
|
The file Question @beaulebens should the periods at the end of these descriptions be removed? because some are used as labels for toggles. Update: never mind, I saw Michael's PR https://github.com/Automattic/jetpack/pull/6259/files |
|
About the I've now restored the file and removed the periods at the end of the sentences. |
|
@eliorivero since it's generated, should we remove it from version control? |
|
Yes, we should do it. Btw this now is good to go 🐑 |
Fixes #6214
Now both
typeswill betypeNot sure what the deal with module headings is, but I'm starting to think the one one
feature/settings-overhaulis wrong.