Closed
Conversation
Contributor
Author
|
Closed in favour of #5996 - we can re-open and apply if that's controversial :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We've had some reports of our cron jobs exceeding timeouts and causing errors on WP Engine (and possibly other sites).
On reflection, having a loop which just tries to send stuff until it runs out of time is probably bad behaviour. In addition, we already have code in there which tries to allow more time to do sending if there's no
max_execution_timeset.This PR removes the loop that sends from cron, and just executed a single send. This may greatly slow down full sync on larger sites - perhaps - but should be sufficient for periodically syncing constants and callables.
It's probably worth it in order to be a better plugin citizen.